Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression from #8 #10

Merged
merged 3 commits into from Jan 17, 2018

Conversation

Projects
None yet
2 participants
@Kocal
Copy link
Contributor

commented Jan 17, 2018

Fix for #9.

Unfortunately I was not able to write a test (I don't have the time for 馃槤), but I directly tested my fix (with yarn link) and it's working as expected:

selection_033

@azz

This comment has been minimized.

Copy link
Owner

commented Jan 17, 2018

Hi, thanks for the fix! I think this is actually a regression from #8, missing --diff-filter

? getLines(runGit(directory, ['diff', '--name-only', '--cached', revision]))

Should be:

 ? getLines(runGit(directory, ['diff', '--name-only', '--cached', '--diff-filter=ACMRTUB', revision])) 

Could you update the PR with this change instead?

@Kocal

This comment has been minimized.

Copy link
Contributor Author

commented Jan 17, 2018

Oh, I didn't think about this.

Thanks, I'm updating my PR

@Kocal Kocal force-pushed the Kocal:fix/error-when-staged-file-does-not-exist branch from 96bc7c3 to 6bf12a4 Jan 17, 2018

@azz

azz approved these changes Jan 17, 2018

Copy link
Owner

left a comment

Looks good, pending CI 馃槃

@azz azz merged commit 48073d8 into azz:master Jan 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@azz

This comment has been minimized.

Copy link
Owner

commented Jan 17, 2018

Thanks for your PR!

@azz

This comment has been minimized.

Copy link
Owner

commented Jan 17, 2018

@Kocal Kocal changed the title Add 芦 fileExists 禄 filter Regression from #8 Jan 29, 2018

@Kocal Kocal deleted the Kocal:fix/error-when-staged-file-does-not-exist branch Dec 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.