Regression from #8 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the fix! I think this is actually a regression from #8, missing Should be: ? getLines(runGit(directory, ['diff', '--name-only', '--cached', '--diff-filter=ACMRTUB', revision])) Could you update the PR with this change instead? |
This reverts commit d8f5156.
|
Oh, I didn't think about this. Thanks, I'm updating my PR |
Kocal
force-pushed
the
fix/error-when-staged-file-does-not-exist
branch
from
96bc7c3
to
6bf12a4
Compare
|
Thanks for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #9.
Unfortunately I was not able to write a test (I don't have the time for 馃槤), but I directly tested my fix (with
yarn link) and it's working as expected: