Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bundleXpcf] exit code is 0 when direct dependency is not found (error in logs) #27

Open
jim-bcom opened this issue Feb 21, 2024 · 1 comment

Comments

@jim-bcom
Copy link

HOW TO REPRODUCE

  • call remaken bundleXpcf with a non existant deps in the file passed via --pkgdeps

EXPECTED BEHAVIOR

  • execution stops, or, if it must continue to process the XPCF config file, gives at least an error message at the end, andthe exit status is not 0

OBSERVED BEHAVIOR

  • log shows an error:
[2024-02-21 16:53:44.217270] [0x00007f23bae57d80] [error]   Error : <dep name> dependency: no shared library found from ....

But even if step => bundling direct dependencies is interrupted, the execution goes on by processing the XPCF config file and exit status is 0 (no error).

@jim-bcom
Copy link
Author

Most likely due lack of check of returned value here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant