-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find a way to fix R locale
in Nix for darwin
and linux
#50
Comments
so linux and windows should be done with 9390e28 but now we need to find how to deal with Darwin |
great news about the first one! :-) |
@b-rodrigues I'll bump a patch version today |
@b-rodrigues the patch is not working for me, both on Rocky linux and Ubuntu it doesn't.
|
I am rolling back |
@b-rodrigues maybe we can do something like what is done here, but using https://gitlab.haskell.org/ghc/ghc.nix/-/blob/master/default.nix#L125 From the response in #48 I would assume it works out of the box for macOS and there is no locale issue, but I'm guessing.
|
This is some summarizing thread regarding the "nix locale" topic. ES-Nix/locale#1 |
@b-rodrigues actually this is working for my two systems, rocky and ubuntu:
What about specifically going for |
seems like we really need all locales inherited in
|
I finally managed to get it working like this, but I had to set the
Then, this works like a charm (we also need a OS-dependent switch in
|
I tested on my rocky again today, and setting |
However, what is at the moment my favorite solution is explicitly set all necessary locale envvars in
|
Interesting, we would need to see if this works in CI and also on macOS. Could you set up a macOS runner and so we could see what comes out of it? Also this would simplify the R code quite a bit since we wouldn’t need to generate anything with R |
Unfortunately, it is planned latest end of Q4 this year by GitHub. |
Isn’t that just for Apple Sillicon architecture? macOS on x86_64 is supported https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md |
yes, true, let me do that :-) |
Do you know how to make an expression conditional? Doing this only for macOS, can I just use
|
This is to have a universal clean solution, since we did a quick-fix for #48
The text was updated successfully, but these errors were encountered: