Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not hide children on copy or localize #400

Open
jonakieling opened this issue May 4, 2023 · 4 comments
Open

Do not hide children on copy or localize #400

jonakieling opened this issue May 4, 2023 · 4 comments
Assignees

Comments

@jonakieling
Copy link

Hi there,

Issue

when an instance runs without neverHideAtCopy the child elements will be hidden after copying.

This is an issue when some of the originals are hidden and some are not. This information is lost with the copied elements.

In our cases the hiding or not hiding of the container itself is sufficient.

Proposals

  1. We patched the CommandMapPostProcessingHook to always set neverHideAtCopy for child elements.
  2. This could be a configuration option for containers instead which would be more flexible but more complex.

Kind regards
Jona

@tastendruecker
Copy link

tastendruecker commented May 23, 2023

+1! Especially in complex container structures it is quite annoying for editors to un-hide every child element of a copied container. Would be really nice if just the copied container were hidden.

@achimfritz
Copy link
Contributor

Hi guys, i would suggest to use the value of the "original" DataHandler (passed to the Methods)?, like

$localDataHandler->neverHideAtCopy = $dataHandler->neverHideAtCopy

for $dataHandler->neverHideAtCopy (can be easily implemented) and TYPO3-Core methods for general use cases:

https://docs.typo3.org/m/typo3/reference-tca/main/en-us/Ctrl/Properties/HideAtCopy.html
https://docs.typo3.org/m/typo3/reference-tsconfig/main/en-us/PageTsconfig/TceMain.html#pagetcemaintables-disablehideatcopy

i would not like to introduce such a special case into the EXT:container

@achimfritz achimfritz self-assigned this Oct 11, 2023
@kitzberger
Copy link
Contributor

@achimfritz, with your suggestion integrators would have to come up with some sort of CType based tsconfig override, right? Or would you do that in EXT: container already?

I'd favor the solution with the least possible todos for integrators and would be fine with just respecting hideOnCopy for the container itself and disabling it for all children, so their actual hidden value remains unaltered as @jonakieling suggested.

@saitho
Copy link
Contributor

saitho commented Apr 23, 2024

👍 We're also discussing this currently with our client.

Hiding the container after copy is sufficient to hide it in the frontend until contents have been adjusted.
It's tedious for our editors to copy a container with let's say 20 elements and needing to enable them one-by-one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants