Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo: Not working as expected after pasting #251

Closed
JannikStreek opened this issue Jan 30, 2024 · 2 comments
Closed

Undo: Not working as expected after pasting #251

JannikStreek opened this issue Jan 30, 2024 · 2 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@JannikStreek
Copy link
Member

Describe the bug
When pasting some nodes, and the undo button is pressed, undo is essentially going always just one node back instead of going back the whole paste operation.

To Reproduce
Steps to reproduce the behavior:

  1. Paste some nodes
  2. Click undo

Expected behavior
All pasted nodes should be "undone"

@JannikStreek JannikStreek added the bug Something isn't working label Jan 30, 2024
@sorenjohanson
Copy link
Contributor

Issue in detail is this:

When pasting nodes, the snapshot is updated sequentially, so instead of going from eg. 5 to 7 nodes (pasting 2 nodes), it goes from 5 to 6 to 7 nodes. In turn, the undo function literally just takes the latest snapshot and removes the last node from it.

Right now I think this'd require a rework of the way snapshots work, to keep both an old snapshot and a new one which we could undo, instead of updating it sequentially and just removing an index like we're doing it right now.

@JannikStreek
Copy link
Member Author

then just leave this for now - I don't think its worth a big refactoring. I just stumbled upon this as this is not what I personally would expect as a user. We can refactor this when the need arises.

@JannikStreek JannikStreek added the wontfix This will not be worked on label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants