Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Use squidclient for unit test #33

Merged
merged 3 commits into from
Oct 4, 2020

Conversation

gianluca-mascolo
Copy link
Contributor

Changed docker-compose.test.yml to use squidclient

  • reuse of the same image for build and test
  • insertion of healtcheck into proxy service
  • usage of squidclient in sut service
  • URL check against postman echo service because it is a declared test service and it can return 200 OK (e.g. google.com return 301)
  • usage of grep is not ideal but squidclient does not use exit status to distinguish between http return codes

@b4tman
Copy link
Owner

b4tman commented Oct 3, 2020

Hello!

Thank you for contribution, again! :)

in Docker Hub build log:

Starting Test in docker-compose.test.yml...
The Compose file './docker-compose.test.yml' is invalid because:
Unsupported config option for services.proxy: 'healthcheck'

Looks like autotests on Docker Hub do not support 'healthcheck' config option. Or may be version 2.1 file format required.

However test passes on GitHub Actions.

@gianluca-mascolo
Copy link
Contributor Author

Looks like autotests on Docker Hub do not support 'healthcheck' config option. Or may be version 2.1 file format required.

However test passes on GitHub Actions.

Hello,
I tried to fix the docker-compose version. Just to let you know I'm contribute in this project because I use your docker image while studying k8s, if you are interested you can find my repo here: https://github.com/gianluca-mascolo/squid-kubeio-filter

Thanks
Ciao
Gianluca

@b4tman
Copy link
Owner

b4tman commented Oct 4, 2020

in Docker Hub build log:

The Compose file './docker-compose.test.yml' is invalid because:
services.proxy.healthcheck value Additional properties are not allowed ('start_period' was unexpected)

start_period for healthchecks was added in 2.3 version

@b4tman b4tman merged commit c3138ce into b4tman:master Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants