Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark and remove "Snapshot" based assertion #974

Closed
Tracked by #962
linkdotnet opened this issue Feb 9, 2023 · 2 comments
Closed
Tracked by #962

Mark and remove "Snapshot" based assertion #974

linkdotnet opened this issue Feb 9, 2023 · 2 comments

Comments

@linkdotnet
Copy link
Sponsor Collaborator

Follow up to #968

The snapshop-based assertion-API is deprecated and will most probably be removed with v2 of bUnit.

var changes = cut.GetChangesSinceFirstRender();

changes.ShouldHaveChanges(...)

Therefore we want to mark the API obsolete as well as remove the documentation around those functions.
@egil egil mentioned this issue Mar 1, 2023
Closed
18 tasks
@linkdotnet
Copy link
Sponsor Collaborator Author

To address 100% of the ticket we could add the ObsoleteAttribute on v1.

@linkdotnet
Copy link
Sponsor Collaborator Author

Done on v2 - would close this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@linkdotnet