Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NBB and Shadow-cljs can't work off the same :require code for third party NPM libraries #256

Closed
dmg46664 opened this issue Sep 13, 2022 · 0 comments

Comments

@dmg46664
Copy link
Contributor

version

"nbb": "^0.7.134",

platform

MacOSX
Node.js v18.8.0

problem

NBB and Shadow-cljs can't :require WebSocketServer from the ws NPM package using the same code path.

As described in the #nbb slack channel:
https://clojurians.slack.com/archives/C029PTWD3HR/p1663073274434959

repro

Example written up here with demonstration of the problem in the README:
https://github.com/dmg46664/problems/tree/main/03_nbb_and_shadow_import

expected behavior

Expected behaviour is to not have to change the cljs code in order to get the example running on both platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant