Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly more intuitive CLI command / subcommand naming? #18

Closed
teodorlu opened this issue Apr 3, 2022 · 6 comments
Closed

Possibly more intuitive CLI command / subcommand naming? #18

teodorlu opened this issue Apr 3, 2022 · 6 comments

Comments

@teodorlu
Copy link
Contributor

teodorlu commented Apr 3, 2022

Working on #16, I didn't find any place to fit in "list available versions for a library" into the current subcommand stucture. Toplevel add doesn't fit - we're not adding versions. Yet, listing available versions is very much related to adding a version.

Grouping dependency stuff together makes sense to me. For example:

# :lib as option - or as the first command
neil dep add :lib org.clojure/clojure
neil dep add org.clojure/clojure

# dep versions subcommand can have same structure.
neil dep versions :lib org.clojure/clojure
neil dep versions org.clojure/clojure

Not sure about what to do about the rest of the add subcommand. Perhaps just keep it. We woiuld have two ways of adding a dependency (neil dep add and neil add dep).

@borkdude
Copy link
Contributor

borkdude commented Apr 3, 2022

I agree that dep add is the way to go. We should keep add dep for backward compatibility, perhaps we can just "rewrite" add dep to dep add or so.

@borkdude
Copy link
Contributor

borkdude commented Apr 3, 2022

Was this already done?

@teodorlu
Copy link
Contributor Author

teodorlu commented Apr 3, 2022

No - I removed the neil dep add entrypoint. Should be a single-line change to add it back.

@borkdude
Copy link
Contributor

borkdude commented Apr 3, 2022

Do you want to first do this, or do a release with the previous stuff first?

@teodorlu
Copy link
Contributor Author

teodorlu commented Apr 3, 2022

If you also want the neil dep add entrypoint in, I'd be happy to create a tiny second PR :)

@teodorlu
Copy link
Contributor Author

teodorlu commented Apr 3, 2022

Here: #19

@borkdude borkdude closed this as completed Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants