Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newlines should be added when adding dependencies #209

Closed
borkdude opened this issue Mar 25, 2024 · 2 comments
Closed

Newlines should be added when adding dependencies #209

borkdude opened this issue Mar 25, 2024 · 2 comments

Comments

@borkdude
Copy link
Contributor

Sure, here is a (hopefully) reproducible steps:

  1. Run docker run --rm -it --platform linux/amd64 homebrew/brew:4.2.15 /bin/bash
  2. Install neil and java: brew install babashka/brew/neil, brew install java.
  3. echo {:deps {}} > deps.edn
  4. neil add dep com.s-exp/hirundo
  5. neil add dep metosin/malli
  6. cat deps.edn

In my m1 max mac, step 3 ~ 6 in a tmp/xx folder will suffice to reproduce it.
I added step 1 and 2 for better reproducibility.

Originally posted by @zhming0 in #208 (reply in thread)

@borkdude
Copy link
Contributor Author

borkdude commented Mar 26, 2024

A repro purely with rewrite-edn:

 (-> (e/parse-string "{}") (e/assoc-in [:deps 'org.clojure/clojure] {:mvn/version "1.10.2"}) str e/parse-string (e/assoc-in [:deps 'org.foo/foo :mvn/version] "1.10.2") str)
;; => 
"{:deps {org.clojure/clojure {:mvn/version \"1.10.2\"} org.foo/foo {:mvn/version \"1.10.2\"}}}"

@borkdude
Copy link
Contributor Author

Also reported here: borkdude/rewrite-edn#36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant