Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create automatically fixtures output.js files for new tests #27

Merged
merged 1 commit into from
Jun 4, 2018

Conversation

Andarist
Copy link
Collaborator

@Andarist Andarist commented Jun 3, 2018

Why:
So fixtures mode works more like snapshots - if output is absent, just create it.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great idea! Let's just fix the merge conflicts and the build 👌

@Andarist Andarist force-pushed the auto-create-fixture-output branch from 744c3c1 to cda23d8 Compare June 4, 2018 11:45
@codecov-io
Copy link

codecov-io commented Jun 4, 2018

Codecov Report

Merging #27 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #27   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         105    109    +4     
  Branches       24     25    +1     
=====================================
+ Hits          105    109    +4
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3e1ad2...617efe0. Read the comment docs.

@Andarist Andarist force-pushed the auto-create-fixture-output branch from cda23d8 to 617efe0 Compare June 4, 2018 11:47
@Andarist
Copy link
Collaborator Author

Andarist commented Jun 4, 2018

Rebased and added test

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Do you think should document this?

@kentcdodds kentcdodds merged commit d48a8fc into babel-utils:master Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants