Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added 'fixtureOutputExt' configuration option #73

Merged
merged 2 commits into from May 27, 2020
Merged

added 'fixtureOutputExt' configuration option #73

merged 2 commits into from May 27, 2020

Conversation

CzBuCHi
Copy link
Contributor

@CzBuCHi CzBuCHi commented May 25, 2020

details can be found in issue #72


ps: i was forced to commit via git commit -no-verify because otherwise im getting this error:

c:\projects\github\babel-plugin-tester>git commit
husky > pre-commit (node v12.16.3)
sh: C:projectsgithubbabel-plugin-testernode_modules.binkcd-scripts.CMD: command not found
husky > pre-commit hook failed (add --no-verify to bypass)

(im guessing, that something is stripping \ from path and also i dont have file
C:\projects\github\babel-plugin-tester\node_modules\.binkcd-scripts.CMD on my pc even after deleting node_modules and caling npm install again ... , also i have no idea what husky is ...)

OS: windows 10 v 1909 build 18363.836
npm -v: 6.14.4
node -v: v12.16.3

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2020

Codecov Report

Merging #73 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #73   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          157       160    +3     
  Branches        37        38    +1     
=========================================
+ Hits           157       160    +3     
Impacted Files Coverage Δ
src/plugin-tester.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5569f4...f5c4a84. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Could we get docs as well?

@CzBuCHi
Copy link
Contributor Author

CzBuCHi commented May 27, 2020

Sure thing....

PS: english isn`t my first language, so please check for wierdness and typos ...

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super 👍 thanks!

@kentcdodds kentcdodds merged commit ae67eee into babel-utils:master May 27, 2020
@kentcdodds
Copy link
Member

@all-contributors please add @CzBuCHi for code, tests, and docs

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @CzBuCHi! 🎉

@kentcdodds
Copy link
Member

🎉 This PR is included in version 9.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants