Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to @babel/preset-env #69

Open
clarknelson opened this issue Nov 11, 2019 · 3 comments
Open

Update to @babel/preset-env #69

clarknelson opened this issue Nov 11, 2019 · 3 comments

Comments

@clarknelson
Copy link

The recommended preset is read-only by babel. We should update the docs to reflect the new package.

@existentialism
Copy link
Member

existentialism commented Nov 12, 2019

@clarknelson agree! care to send a PR?

@clarknelson
Copy link
Author

clarknelson commented Nov 12, 2019

I would but i'm not 100% sure my implementation is even working. Here is my config:

module.exports = {
  optimize: true,
  ...
  plugins: {
    babel: {
      presets: [
        ["@babel/preset-env", {
          targets: {
            browsers: ['last 2 versions']
          }
        }]
      ]
    }
  }
};

I noticed yesterday that one of my projects was not removing Symbol for IE11 projects, where i'm pretty sure this has worked with the same setup in the past. I came here to make sure my config was correct, but now i'm not sure what to do. I guess I will have to debug, and if I can get it working I will update the readme.

@jngbng
Copy link

jngbng commented Jan 20, 2021

@clarknelson Thanks. it works for me, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants