Skip to content
This repository has been archived by the owner on Aug 18, 2021. It is now read-only.

New https://github.com/eslint/eslint-scope project #438

Closed
JamesHenry opened this issue Feb 12, 2017 · 4 comments
Closed

New https://github.com/eslint/eslint-scope project #438

JamesHenry opened this issue Feb 12, 2017 · 4 comments

Comments

@JamesHenry
Copy link
Member

Hey @hzoo et al 馃槃

I just wanted to make sure you are aware that we have officially forked escope at https://github.com/eslint/eslint-scope

There were a couple of reasons for this, but most recently it was not possible to work with the maintainers of escope to accept PRs relating to extensions to ESTree (e.g. for features relating to typeAnnoations)

We will be working to replace escope with eslint-scope in ESLint as part of the next major release (v4).

@nzakas was keen that you guys were aware of that in plenty of time, as I know you currently have to do some funky stuff around scopes in this project.

Please let us know if you have any questions!

@zertosh
Copy link
Member

zertosh commented Mar 24, 2017

@JamesHenry, I'm actively working on rewriting this package so that flow types are perfectly scoped. Not only so that eslint can make better use of the scope info, but also to power other fb tooling that needs type data (e.g.: code generators that need to resolve types). Would you accept a series of PRs in eslint-scope that add type annotation support?

@soda0289
Copy link
Contributor

soda0289 commented Apr 2, 2017

@zertosh I have been working on adding type annotation and decorator support to eslint-scope, since typescript would benefit from this as well. If we added type parameter support as well would that cover everything for flow?

@hzoo
Copy link
Member

hzoo commented Jun 15, 2017

@vitorbal updated to eslint-scope in #461 but we should at least update the devDep to check that tests all still pass

"eslint": "^3.18.0",

@hzoo
Copy link
Member

hzoo commented Jan 9, 2018

I think we can close now since we use this as a dep

"eslint-scope": "~3.7.1",

@hzoo hzoo closed this as completed Jan 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants