Skip to content
This repository has been archived by the owner on Jun 29, 2018. It is now read-only.

Can you export buildExternalHelpers for rollup-babel-standalone ? #87

Closed
jetiny opened this issue Jun 6, 2017 · 7 comments
Closed

Can you export buildExternalHelpers for rollup-babel-standalone ? #87

jetiny opened this issue Jun 6, 2017 · 7 comments

Comments

@jetiny
Copy link
Contributor

jetiny commented Jun 6, 2017

export const availablePlugins = {};
export const availablePresets = {};
// export buildExternalHelpers
export const buildExternalHelpers = Babel.buildExternalHelpers;
@jetiny jetiny changed the title can you export buildExternalHelpers for rollup-babel-standalone ? Can you export buildExternalHelpers for rollup-babel-standalone ? Jun 6, 2017
@Daniel15
Copy link
Member

Daniel15 commented Jun 6, 2017

What is "rollup-babel-standalone"?

This should be easy to do, feel free to send a pull request.

@jetiny
Copy link
Contributor Author

jetiny commented Jun 6, 2017

Thanks.
rollup website

@loganfsmyth
Copy link
Member

This seems like a reasonable thing to expose. The question above isn't asking what Rollup is, it's asking how that ties to standalone. I don't get how you'd combine Rollup and babel-standalone. The point of babel-standalone is non-Node usage, and Rollup is entirely Node.

@jetiny
Copy link
Contributor Author

jetiny commented Jun 6, 2017

It's for node only, For some reasons we need to use babel-standalone with rollup-plugin-babel, but it need buildExternalHelpers

@Daniel15
Copy link
Member

Daniel15 commented Jun 6, 2017

Added in #88

@Daniel15 Daniel15 closed this as completed Jun 6, 2017
@loganfsmyth
Copy link
Member

@jetiny There's no benefit to using babel-standalone with Rollup. If you're finding that necessary, I'd recommend exploring why that is, since you're now reinventing existing tooling for Rollup.

@jetiny
Copy link
Contributor Author

jetiny commented Jun 6, 2017

Out CI is too slow, even if we use yarn and a private cnpm registry, we must cut down the dependencies of npm packages

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants