Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not highlighting => functions and template strings ` poor readability #241

Closed
vans163 opened this issue Feb 19, 2016 · 2 comments
Closed

Comments

@vans163
Copy link

vans163 commented Feb 19, 2016

Template strings using grave accent are being highlighted very poorly IMO. They should use the same highlight as "". Atm they blend in with everything else and its hard to tell if its a string or code. Atleast highlight the ` gold as well to see where the string starts and ends.

This seems to be a regression as the image in the README shows grave accent template strings highlighted properly.

Functions using => syntax are not being highlighted in class definitions. This is a deal breaker as using React with ES6 classes you are required to use them to pass this around.

@vans163 vans163 changed the title Not highlighting => functions and template strings poor readability Not highlighting => functions and template strings ` poor readability Feb 19, 2016
@zertosh
Copy link
Member

zertosh commented Nov 27, 2016

In "re-rewrite babel-sublime" #293, I intend to scope the backticks as "string". However the content of the interpolated expression is purposefully not scoped as part of the string. This is so themes don't turn the entire expression "string colored".

@zertosh zertosh closed this as completed Nov 27, 2016
@vans163
Copy link
Author

vans163 commented Dec 2, 2016

I do not agree with this. A string is a string and should appear as a string, even if its being built in a dynamic way. When you see things inside grave accented highlighted as not a string, its hard to tell what it belongs to, since the grave accents are so hard to see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants