Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scoping JSX snippets to HTML? #48

Closed
joemaller opened this issue Feb 24, 2015 · 2 comments
Closed

Scoping JSX snippets to HTML? #48

joemaller opened this issue Feb 24, 2015 · 2 comments
Labels

Comments

@joemaller
Copy link

Just started thinking about this, but I wanted to get a conversation going.

It should be possible to scope React's JSX blocks to HTML, most likely named text.html.jsx. If that worked, wouldn't we suddenly gain access to all of the HTML tools available to Sublime? At very least, this should enable Sublime's build-in Expand Selection to Tag. Formatters/Tidy would be welcome.

I haven't looked into what they're doing, but Allan Hortle's JSX package does allow Expand Selection to Tag to function correctly.

@zertosh
Copy link
Member

zertosh commented Feb 24, 2015

Interesting. I wonder if it breaks eslint. It shouldn't break JSXHint because there's a transpile step there. But I think eslint only lints certain scopes. I could be mistaken. I'll investigate. Good call!

@zertosh zertosh added the todo label Feb 24, 2015
@zertosh
Copy link
Member

zertosh commented Mar 15, 2015

Hey @joemaller, I fixed the "Expand Selection to Tag" bug in #70. I also looked into scoping JSX as text.html.* and it didn't really work with other HTML tools as you suggested. If you have any luck with this, PRs are welcome or open another issue.

@zertosh zertosh closed this as completed Mar 15, 2015
@zertosh zertosh added bug and removed todo labels Mar 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants