Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename syntax name #5

Closed
dashed opened this issue Jan 17, 2015 · 6 comments · Fixed by #10
Closed

Rename syntax name #5

dashed opened this issue Jan 17, 2015 · 6 comments · Fixed by #10

Comments

@dashed
Copy link

dashed commented Jan 17, 2015

Then Syntax -> Open all with current extension as... -> JavaScript JSX.

IMO, I think JavaScript JSX should be renamed to something else (maybe JavaScript 6to5?). JSX isn't the only thing that has highlighting support, but generally/ideally anything that 6to5 supports syntactically (e.g. ES7+).

@dashed
Copy link
Author

dashed commented Jan 17, 2015

Also, the name nearly confused me because sublime-react also have a similar name: https://github.com/reactjs/sublime-react/blob/4dba5d41b8174df35af00299fcb2986464a747d5/syntax/jsx/tmLanguage/JavaScript%20(JSX).JSON-tmLanguage#L2

@zertosh
Copy link
Member

zertosh commented Jan 17, 2015

Yeah, I'm totally cool with this. FYI: The one thing we can't change is the filename, otherwise SublimeLinter-jsxhint might not work. The lowercased tmLanguage filename is the syntax's name. And SublimeLinter-jsxhint only has `'jsx', 'javascript_jsx', 'javascript (jsx)' listed.

Can I get another 👍 for the rename?

@gpbl
Copy link
Contributor

gpbl commented Jan 17, 2015

👍

@STRML
Copy link

STRML commented Jan 17, 2015

Feel free to rename it, please just respond to this ticket with the target rename and I will add it to sublimelinter-jsxhint.

@zertosh
Copy link
Member

zertosh commented Jan 17, 2015

Done. Renamed to JavaScript 6to5

@zertosh zertosh closed this as completed Jan 17, 2015
@STRML
Copy link

STRML commented Jan 17, 2015

SublimeLinter-JSXHint 1.1.0 now has support for this name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants