-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reactjs/sublime-react deprecation #96
Comments
Are you going to add syntax highlight for *.cjsx files (Coffee Script React)? That would be cool. Thanks. |
With this deprecation, support for CJSX dissappeared. All of my files now look like shit. Is there any chance you will support CJSX aswell? |
CJSX :( |
I'm afraid that I have no plans of adding CJSX support since babel doesn't support coffeescript syntax. Maybe @jsdf can take old CJSX syntax definitions and maintain them? |
Kinda surprised by this deprecation. @JakovlevDS @miklschmidt @vegetableman You guys could just copy and paste the following as a new sublime package (or into your sublime user folder): https://github.com/reactjs/sublime-react/tree/ec17f5dfd00eaa326dc299a4febd46cac21e7904/syntax/jsx-coffee @zertosh What do you mean by "bring back snippets"? |
@dashed I'm going to add back the React snippets and some new ES6 ones as a separate package so they can be opt-in and independent of the syntax definition. https://github.com/babel/babel-sublime-snippets |
Just adding in my support for CoffeeScript support! Thanks for your time and effort :) |
cjsx :( |
FYI sublime-react in its current state already/still provides snippets. I'm not sure it's worth duplicating that effort, unless your focus is making them customizable based on your transform configuration. Not everyone using snippets is using Babel. |
Re: CJSX, I'd encourage the coffeescript community to maintain a separate project altogether. Supporting both languages in sublime-react was –in hindsight– not a great move, since all of React, JSX and ES6 tend to introduce changes at different points in time. I realize that this is an inconvenient transition for coffeescript users, but it should make future upgrades easier for both sides. |
@jgebhardt We had snippets but then I removed them (see #31). I've been meaning to make a package just for them, now seems like a good time. As for CJSX, I'd be more than happy to add a link to whatever project takes over it. |
@zertosh I understand they were removed, but sublime-react already provides snippets (actually, since removing the syntax in favor of Babel, that's all it provides). I don't plan on removing the remaining package, as many people are using it specifically for snippets. What improvements do you envision babel-sublime-snippets to provide over sublime-react? |
@jgebhardt More ES6 specific stuff like I based the original snippets on what was on sublime-react, but I switched them to using ES6 syntax, like short method definitions. They're all listed here https://github.com/babel/babel-sublime/blob/master/SNIPPETS.md. |
The deprecation was extremely annoying. Why can't we have both babel and reactjs (seriously, there is no legitimate reason to completely break it - sure stop supporting it/working on it, but don't just make it stop working)? It took me a while to even realize there was a deprecation, I had to look at the repo and see the latest commit. |
@n1ghtmare i agree, it's not cool deprecating (actually not deprecating, directly removing without warning) something without a proper substitution. Is there anyone with experience in syntax definitions who could maintain a new repo? If not i'll take a look at throwing together a repo and sublime package, but i have no idea what i'm doing. |
As it appears that CJSX will never be supported in this package, I recommend migrating our efforts to aponxi/sublime-better-coffeescript. |
It is definitely not cool to wake up one morning and seeing your cjsx files in sublime look like plain text files without having any proper feature substitution. Before deprecating something unexpectedly I would expect authors to think about all user current using the plugin and giving them time to adapt accordingly. Thanks for taking them into account next time. |
@alanrubin I absolutely agree, that was definitely not cool. I ended up setting |
@alanrubin @n1ghtmare The repo is still there. All you have to do is clone it and point it to the commit before the deprecation. git clone git@github.com:reactjs/sublime-react.git
cd sublime-react
git checkout ec17f5d |
@zertosh Yep, thanks, that's what I did, I've created a fork (then reverted the changes) and added it as a source to Package Control. Then set |
I've got a package hosted here, with the non-syntax highlighting stuff removed: You can add this as a repo manually. Also improved the highlighting a wee bit -- it wasn't highlighting HTML attributes in the sublime-react version |
For those unaware, adding @kwood's repo manually involves:
|
Thanks for sharing the detailed steps. @chrisvfritz . you rock 👍 |
Thank you @kwood @chrisvfritz, this is VERY helpful! |
TODO:
The text was updated successfully, but these errors were encountered: