Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reactjs/sublime-react deprecation #96

Closed
3 tasks done
zertosh opened this issue Apr 14, 2015 · 24 comments
Closed
3 tasks done

reactjs/sublime-react deprecation #96

zertosh opened this issue Apr 14, 2015 · 24 comments

Comments

@zertosh
Copy link
Member

zertosh commented Apr 14, 2015

TODO:

  • New screenshots and readme w/o comparison.
  • Bring back snippets and update to React 0.13.0
  • Add note thanking @jgebhardt and @zpao
@zertosh zertosh added the todo label Apr 14, 2015
@refacrot
Copy link

Are you going to add syntax highlight for *.cjsx files (Coffee Script React)? That would be cool. Thanks.

@miklschmidt
Copy link

With this deprecation, support for CJSX dissappeared. All of my files now look like shit. Is there any chance you will support CJSX aswell?

@vegetableman
Copy link

CJSX :(

@zertosh
Copy link
Member Author

zertosh commented Apr 15, 2015

I'm afraid that I have no plans of adding CJSX support since babel doesn't support coffeescript syntax. Maybe @jsdf can take old CJSX syntax definitions and maintain them?

@dashed
Copy link

dashed commented Apr 15, 2015

Kinda surprised by this deprecation.


@JakovlevDS @miklschmidt @vegetableman

You guys could just copy and paste the following as a new sublime package (or into your sublime user folder): https://github.com/reactjs/sublime-react/tree/ec17f5dfd00eaa326dc299a4febd46cac21e7904/syntax/jsx-coffee


@zertosh What do you mean by "bring back snippets"?

@zertosh
Copy link
Member Author

zertosh commented Apr 15, 2015

@dashed I'm going to add back the React snippets and some new ES6 ones as a separate package so they can be opt-in and independent of the syntax definition. https://github.com/babel/babel-sublime-snippets

@jessepollak
Copy link

Just adding in my support for CoffeeScript support! Thanks for your time and effort :)

@dstauffer
Copy link

cjsx :(

@jgebhardt
Copy link

FYI sublime-react in its current state already/still provides snippets. I'm not sure it's worth duplicating that effort, unless your focus is making them customizable based on your transform configuration. Not everyone using snippets is using Babel.

@jgebhardt
Copy link

Re: CJSX, I'd encourage the coffeescript community to maintain a separate project altogether. Supporting both languages in sublime-react was –in hindsight– not a great move, since all of React, JSX and ES6 tend to introduce changes at different points in time. I realize that this is an inconvenient transition for coffeescript users, but it should make future upgrades easier for both sides.

@zertosh
Copy link
Member Author

zertosh commented Apr 15, 2015

@jgebhardt We had snippets but then I removed them (see #31). I've been meaning to make a package just for them, now seems like a good time.

As for CJSX, I'd be more than happy to add a link to whatever project takes over it.

@jgebhardt
Copy link

@zertosh I understand they were removed, but sublime-react already provides snippets (actually, since removing the syntax in favor of Babel, that's all it provides). I don't plan on removing the remaining package, as many people are using it specifically for snippets.

What improvements do you envision babel-sublime-snippets to provide over sublime-react?

@zertosh
Copy link
Member Author

zertosh commented Apr 15, 2015

@jgebhardt More ES6 specific stuff like import, something for arrow functions, etc. And as far as React stuff, things like import React, {PropTypes} from 'react;, a skeleton for React ES6 classes, etc.

I based the original snippets on what was on sublime-react, but I switched them to using ES6 syntax, like short method definitions. They're all listed here https://github.com/babel/babel-sublime/blob/master/SNIPPETS.md.

@n1ghtmare
Copy link

The deprecation was extremely annoying. Why can't we have both babel and reactjs (seriously, there is no legitimate reason to completely break it - sure stop supporting it/working on it, but don't just make it stop working)? It took me a while to even realize there was a deprecation, I had to look at the repo and see the latest commit.
/rant

@miklschmidt
Copy link

@n1ghtmare i agree, it's not cool deprecating (actually not deprecating, directly removing without warning) something without a proper substitution. Is there anyone with experience in syntax definitions who could maintain a new repo? If not i'll take a look at throwing together a repo and sublime package, but i have no idea what i'm doing.

@chrisvfritz
Copy link

As it appears that CJSX will never be supported in this package, I recommend migrating our efforts to aponxi/sublime-better-coffeescript.

@alanrubin
Copy link

It is definitely not cool to wake up one morning and seeing your cjsx files in sublime look like plain text files without having any proper feature substitution. Before deprecating something unexpectedly I would expect authors to think about all user current using the plugin and giving them time to adapt accordingly. Thanks for taking them into account next time.

@n1ghtmare
Copy link

@alanrubin I absolutely agree, that was definitely not cool. I ended up setting auto_upgrade to false and restoring the Packages folder.

@zertosh
Copy link
Member Author

zertosh commented Apr 19, 2015

@alanrubin @n1ghtmare The repo is still there. All you have to do is clone it and point it to the commit before the deprecation.

git clone git@github.com:reactjs/sublime-react.git
cd sublime-react
git checkout ec17f5d

@n1ghtmare
Copy link

@zertosh Yep, thanks, that's what I did, I've created a fork (then reverted the changes) and added it as a source to Package Control. Then set auto_upgrade back to true.

@kwood
Copy link

kwood commented Apr 22, 2015

I've got a package hosted here, with the non-syntax highlighting stuff removed:
https://github.com/Guidebook/sublime-cjsx

You can add this as a repo manually.

Also improved the highlighting a wee bit -- it wasn't highlighting HTML attributes in the sublime-react version

@chrisvfritz
Copy link

For those unaware, adding @kwood's repo manually involves:

  1. Cmd/Ctrl+P > Package Control: Add Repository > https://github.com/Guidebook/sublime-cjsx
  2. Cmd/Ctrl+P > Package Control: Install Package > sublime-cjsx
  3. Open a *.cjsx file
  4. View > Syntax > Open all with current extension as... > CJSX

@vegetableman
Copy link

Thanks for sharing the detailed steps. @chrisvfritz . you rock 👍

@liorbrauer
Copy link

Thank you @kwood @chrisvfritz, this is VERY helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests