Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Node Versions Support #13

Closed
scurker opened this issue Feb 20, 2018 · 2 comments
Closed

Various Node Versions Support #13

scurker opened this issue Feb 20, 2018 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@scurker
Copy link

scurker commented Feb 20, 2018

This is probably in the early stages, so I apologize if this issue is premature. From the documentation, it looks like the intent is to support node 4 <=, but currently isn't transpiled down to support Node 4.

Node 4 & 5 (no destructuring)

/bin/babel-upgrade
const { isAcceptedNodeVersion, writePackageJSON, writeBabelRC } = require("../src");
      ^
SyntaxError: Unexpected token {

Node 6 (no async)

/src/index.js:59
async function writePackageJSON() {
      ^^^^^^^^
SyntaxError: Unexpected token function

Node 7 (no trailing/last commas)

/src/packageData.js:243
);
^
SyntaxError: Unexpected token )

Otherwise, everything has worked great in node 8 & 9 .

@hzoo
Copy link
Member

hzoo commented Feb 20, 2018

Yeah it's in the readme, didn't get to it yet. #11 (comment)

Or if someone wants to make a PR (use babel + target node 4 in the config with preset-env)

@hzoo hzoo added enhancement New feature or request help wanted Extra attention is needed labels Feb 21, 2018
@hiroppy hiroppy mentioned this issue Feb 21, 2018
@hiroppy
Copy link
Member

hiroppy commented Feb 21, 2018

I created PR:)

@hzoo hzoo closed this as completed in #16 Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants