Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped chokidar dependency of babel-cli to 2.1.8 #10394

Merged
merged 1 commit into from Sep 5, 2019

Conversation

ajaysagar
Copy link
Contributor

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? Yes
License MIT

babel-cli currently depends on chokidar v2.0.4 which pulls in fsevents 1.2.4. This causes installation errors on node 12 (see fsevents/fsevents#278). Bumped chokidar dependency to 2.1.8 which depends on fsevents 1.2.9.

@ajaysagar ajaysagar changed the title Bumped chokidar dependency to 2.1.8 Bumped chokidar dependency of babel-cli to 2.1.8 Sep 4, 2019
@nicolo-ribaudo
Copy link
Member

Is this currently preventing Babel from being installed on node 12?

@ajaysagar
Copy link
Contributor Author

ajaysagar commented Sep 4, 2019

Yes, my project depends on babel/cli@7.5.5 and I always get errors on npm install on node 12. In spite of the errors, transpilation seems fine, however our webpack-dev-server process (configured to watch files) hangs indefinitely and times out while serving our bundle.

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11456/

Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@JLHwung JLHwung merged commit d05bd9e into babel:master Sep 5, 2019
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Dependency ⬆️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants