Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[decorators] fix: support string literal properties #10578

Merged
merged 1 commit into from Oct 21, 2019
Merged

[decorators] fix: support string literal properties #10578

merged 1 commit into from Oct 21, 2019

Conversation

mwhitworth
Copy link
Contributor

Q                       A
Fixed Issues? Fixes #10059
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

As suggested in the issue ticket. Add a basic test case for this too

@buildsize
Copy link

buildsize bot commented Oct 19, 2019

File name Previous Size New Size Change
babel-preset-env.js 2.73 MB 2.73 MB 9 bytes (0%)
babel-preset-env.min.js 1.65 MB 1.65 MB 9 bytes (0%)
babel.js 2.92 MB 2.92 MB 49 bytes (0%)
babel.min.js 1.61 MB 1.61 MB 44 bytes (0%)
test262.tap 4.84 MB [deleted]

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Decorators (Legacy) labels Oct 19, 2019
@nicolo-ribaudo
Copy link
Member

Thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit 5b40845 into babel:master Oct 21, 2019
@fpauser fpauser mentioned this pull request Nov 4, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Nov 14, 2019
Merged
This was referenced Nov 28, 2019
Open
Open
This was referenced Dec 5, 2019
Open
Merged
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2020
Open
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 24, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Decorators (Legacy)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Babel 7 decorators (legacy) break on string literal class properties
3 participants
@mwhitworth @nicolo-ribaudo @JLHwung