chore: test against Node.js 13 #10591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
the
PR: Internal 🏠
| @@ -27,8 +27,8 @@ matrix: | |||
| include: | |||
| - node_js: "node" | |||
| env: JOB=lint | |||
| # We test the latest version on circleci | |||
| - node_js: "11" | |||
| # We test the Node.js 12 on circleci | |||
There was a problem hiding this comment.
Why not run 13 on Circle and make this 12?
There was a problem hiding this comment.
Because circleci/node:13 is not available yet. After it is available we could swap 13 to circleci.
There was a problem hiding this comment.
Gotcha, fwiw, I'm okay with waiting :)
|
Let's merge this now since CI is completely broken; we can move the tests to CircleCI as soon as it is available. |
This was referenced Nov 28, 2019
This was referenced Dec 5, 2019
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run CI against Node.js 13. Fixes may follow if necessary.