Don't use ES6 in the for-of helper #11302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Bug Fix 🐛
jridgewell
approved these changes
Mar 21, 2020
|
Ah, this is identical to the pull request that I was preparing, so I'm pretty sure it works 😄 I wasn't sure how to go about testing it, but since there are no tests in this PR either, I'm guessing it's probably out of scope for this fix. |
existentialism
approved these changes
Mar 21, 2020
|
It's getting harder and harder to remember what is and isn't ES2015 :D |
This was referenced Mar 23, 2020
This was referenced Apr 13, 2020
This was referenced Apr 20, 2020
This was referenced Apr 27, 2020
This was referenced May 5, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that we don't compile the helpers when using Rollup (I think).
@babel/runtimeand inline helpers don't have this problem because they are transpiled.