chore: pin stack-utils to 1.0.2 on legacy node tests #12365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/32725/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 90abf24:
|
JLHwung
force-pushed
the
fix-broken-node-6-tests
branch
2 times, most recently
from
a4cef0b
to
3f1330a
Compare
JLHwung
commented
Nov 16, 2020
.github/workflows/ci.yml
Outdated
| yarn remove jest | ||
| yarn add --dev jest@24 | ||
| # Pin stack-utils to 1.0.2 https://github.com/tapjs/stack-utils/issues/56 | ||
| yarn set resolution --save stack-utils@npm:^1.0.1 1.0.2 |
There was a problem hiding this comment.
It's a bug - yarnpkg/berry#1598
There was a problem hiding this comment.
I am not meant for
yarn set resolution stack-utils 1.0.2
I mean the example usage
yarn set resolution stack-utils@^1.0.1 1.0.2
does not do the trick, but if I add npm:, it works as expected.
yarn set resolution stack-utils@npm:^1.0.1 1.0.2
There was a problem hiding this comment.
Ah, right, it's expected see yarnpkg/berry#1598 (comment). Though we might improve that
JLHwung
force-pushed
the
fix-broken-node-6-tests
branch
from
3f1330a
to
90abf24
Compare
nicolo-ribaudo
approved these changes
Nov 16, 2020
existentialism
approved these changes
Nov 16, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will mark as ready for review once CI is green.
Closes #12364
Note that this PR does not mean Babel 7 does not support Node.js 6 because
stack-utilsis only used injest-message-utils, it is not in Babel dependencies so we can pin it to a working version.