Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update yarn-plugin-babel-release-tool #12369

Merged
merged 1 commit into from Nov 17, 2020
Merged

Update yarn-plugin-babel-release-tool #12369

merged 1 commit into from Nov 17, 2020

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Nov 17, 2020 •
edited by gitpod-io bot

Q                       A
Any Dependency Changes? Committed dev dep update
License MIT

This bug was found by @Andarist.

The problem was:

  • Consider two monorepo packages: A@7.3 and B@7.2. B has a dependency on A@^7.2.
  • B has some changes and it's released as B@7.4.
  • B's dependency on A should be updated to A@^7.3, but this didn't happen because A's version wasn't changed.

This is fixed by nicolo-ribaudo/yarn-plugin-babel-release-tool@4e963d8

@babel-bot
Copy link
Collaborator

babel-bot commented Nov 17, 2020 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/32815/

Andarist
Andarist approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@Andarist Andarist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exceptional work 🚀

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 17, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8f2f2ce:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo nicolo-ribaudo merged commit e8457ea into babel:main Nov 17, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the update-release-tool branch November 17, 2020 16:31
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 17, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@Andarist Andarist Andarist approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nicolo-ribaudo @babel-bot @JLHwung @Andarist