Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move @babel/helper-validator-identifier to ts #12409

Merged
merged 2 commits into from Dec 11, 2020
Merged

refactor: move @babel/helper-validator-identifier to ts #12409

merged 2 commits into from Dec 11, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Nov 27, 2020 •
edited by gitpod-io bot

Q                       A
License MIT

@JLHwung JLHwung added the Flow -> TS Tracking repository migration from Flow to TS label Nov 27, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 27, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4eabc92:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented Nov 27, 2020 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/34991/

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Nov 27, 2020 •
edited

Travis is down so we aren't running Flow checks 🤔

Oh it's the nice "no more free credits thing", we'll need to migrate to GH actions (I can do that now).

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Nov 27, 2020
@JLHwung JLHwung force-pushed the helper-validator-identifier-ts branch 2 times, most recently from 05cdb90 to 49abdd1 Compare December 1, 2020 14:44
@JLHwung JLHwung force-pushed the helper-validator-identifier-ts branch 2 times, most recently from 30eac13 to 4ac16ea Compare December 1, 2020 19:45
@JLHwung JLHwung force-pushed the helper-validator-identifier-ts branch from 4ac16ea to 88a1290 Compare December 10, 2020 21:55
@nicolo-ribaudo nicolo-ribaudo removed the PR: Internal 🏠 A type of pull request used for our changelog categories label Dec 10, 2020
@JLHwung JLHwung force-pushed the helper-validator-identifier-ts branch from 88a1290 to 4eabc92 Compare December 11, 2020 22:07
@JLHwung JLHwung merged commit fc82169 into babel:main Dec 11, 2020
@JLHwung JLHwung deleted the helper-validator-identifier-ts branch December 11, 2020 22:41
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Mar 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
Flow -> TS Tracking repository migration from Flow to TS outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JLHwung @babel-bot @nicolo-ribaudo @existentialism