Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from Travis to GH actions #12412

Merged
merged 8 commits into from Dec 1, 2020
Merged

Migrate from Travis to GH actions #12412

merged 8 commits into from Dec 1, 2020

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Nov 27, 2020 •
edited by gitpod-io bot

Q                       A
License MIT

I got an email from travis a few days ago that they "migrated us to the new plan", and now Travis isn't running on our PRs anymore.
When I check why, I get this error:

Builds have been temporarily disabled for public repositories due to a negative credit balance.

Context : https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing

We could write them an email asking for some free credits and their blog post says that they would probably give us those credits, but:

  • We would have to do this periodically, every time we run out of credits
  • A fellow maintainer with a ton of popular OSS repositories tried contacting them and their support was unresponsive

@babel-bot
Copy link
Collaborator

babel-bot commented Nov 27, 2020 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/33579/

JLHwung
JLHwung approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 27, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7ea3cc6:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

JLHwung
JLHwung reviewed Nov 27, 2020
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
JLHwung
JLHwung reviewed Nov 27, 2020
View reviewed changes
.github/workflows/ci.yml
env:
BABEL_ENV: test

external-parser-tests:

This comment was marked as resolved.

Sign in to view

@nicolo-ribaudo @JLHwung
Update .github/workflows/ci.yml
f427a00 
Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
merceyz
merceyz reviewed Nov 27, 2020
View reviewed changes
.github/workflows/ci.yml Outdated
- uses: actions/cache@v2
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('yarn.lock') }}
Copy link
Contributor

@merceyz merceyz Nov 27, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Yarn cache is identical on all OSes so you can have all the jobs share the same cache

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thanks! I left it with the os name because I wasn't sure about it, but I'll update now.

@nicolo-ribaudo
Copy link
Member Author

I also cleaned up Makefile by removing now unused commands (because they are split across different jobs and/or steps).

merceyz
merceyz reviewed Nov 27, 2020
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@nicolo-ribaudo @merceyz
Update .github/workflows/ci.yml
7ea3cc6 
Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com>
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Nov 28, 2020
Merged
@nicolo-ribaudo nicolo-ribaudo merged commit 4b79ab4 into babel:main Dec 1, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the travis-to-gh branch December 1, 2020 08:55
@merceyz
Copy link
Contributor

merceyz commented Dec 1, 2020

@nicolo-ribaudo Any plans on moving the circle ci part to GH actions as well? Would probably save a minute each time the lockfile changes 🙂

@JLHwung JLHwung mentioned this pull request Dec 1, 2020
Merged
nicolo-ribaudo added a commit to nicolo-ribaudo/babel that referenced this pull request Dec 2, 2020
@nicolo-ribaudo @JLHwung @merceyz
Migrate from Travis to GH actions (babel#12412)
08e87cb 
* Migrate linting to GH actions

* Migrate windows tests

* Migrate parser tests

* Update .github/workflows/ci.yml

Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>

* Run parser tests in a single job

* Use a single yarn cache

* Remove unused commands from Makefile

* Update .github/workflows/ci.yml

Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com>

Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com>
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Mar 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@merceyz merceyz merceyz left review comments

@existentialism existentialism existentialism approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue Priority: High repo automation 🤖
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nicolo-ribaudo @babel-bot @merceyz @existentialism @JLHwung