refactor: move @babel/helper-get-function-arity to ts #12414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JLHwung
commented
Nov 27, 2020
•
JLHwung
commented
| Q | A |
|---|---|
| License | MIT |
JLHwung
added
PR: Internal 🏠
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/33719/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2f84b9f:
|
|
|
||
| export default function (node): number { | ||
| const params: Array<Object> = node.params; | ||
| export default function (node: Function): number { |
There was a problem hiding this comment.
Can this be t.Function? Seeing Function is a bit confusing, because of the built-in Function type.
JLHwung
force-pushed
the
helper-get-function-arity-to-ts
branch
from
4cc3611
to
44e2eb6
Compare
nicolo-ribaudo
approved these changes
Dec 1, 2020
existentialism
approved these changes
Dec 1, 2020
JLHwung
force-pushed
the
helper-get-function-arity-to-ts
branch
from
44e2eb6
to
2f84b9f
Compare
nicolo-ribaudo
pushed a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Dec 2, 2020
* refactor: move @babel/helper-get-function-arity to ts * Review comments * chore: add flow interface
nicolo-ribaudo
removed
the
PR: Internal 🏠
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.