refactor: move @babel/helper-annotate-as-pure to ts #12415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JLHwung
commented
Nov 27, 2020
•
JLHwung
commented
| Q | A |
|---|---|
| License | MIT |
JLHwung
added
PR: Internal 🏠
JLHwung
commented
Nov 27, 2020
| !!leadingComments && | ||
| leadingComments.some(comment => /[@#]__PURE__/.test(comment.value)); | ||
|
|
||
| export default function annotateAsPure(pathOrNode) { | ||
| export default function annotateAsPure( | ||
| pathOrNode: Node | { node: Node }, |
There was a problem hiding this comment.
Since this function does not use Path.prototype, I type the input as { node: Node }.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/33757/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a8da9a8:
|
JLHwung
force-pushed
the
move-helper-annotate-as-pure-to-ts
branch
from
945d91d
to
b8ce51f
Compare
|
I didn't add flow types of this package because none of its dependents are type checked by Flow. Since we are unlikely to enable more Flow type check during the transition, I am good with deferring adding flow types for this package. |
nicolo-ribaudo
approved these changes
Dec 1, 2020
|
Should index have its extension changed to |
JLHwung
force-pushed
the
move-helper-annotate-as-pure-to-ts
branch
from
b8ce51f
to
41e0bad
Compare
existentialism
approved these changes
Dec 1, 2020
JLHwung
force-pushed
the
move-helper-annotate-as-pure-to-ts
branch
from
41e0bad
to
a8da9a8
Compare
nicolo-ribaudo
pushed a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Dec 2, 2020
* refactor: move @babel/helper-annotate-as-pure to ts * chore: add flow types
nicolo-ribaudo
removed
the
PR: Internal 🏠
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.