[babel 8] Enable allowDeclareFields option by default w/ Flow
#12457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
commented
Dec 8, 2020
| @@ -149,6 +149,8 @@ function pushTask(taskName, taskDir, suite, suiteName) { | |||
| }, | |||
| }; | |||
|
|
|||
| delete taskOpts.BABEL_8_BREAKING; | |||
There was a problem hiding this comment.
Without this @babel/core throws about the unknown BABEL_8_BREAKING option.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/34237/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 981e683:
|
cherr-pick of 4903e2e Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
nicolo-ribaudo
force-pushed
the
backport-flow-keep-class-fields
branch
from
c4a49e0
to
981e683
Compare
JLHwung
approved these changes
Dec 8, 2020
hzoo
approved these changes
Dec 8, 2020
nicolo-ribaudo
changed the title
allowDeclareFields Flow option by defaultallowDeclareFields option by default w/ Flow
github-actions
bot
added
the
outdated
nicolo-ribaudo
added
babel 8
PR: Breaking Change 💥
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of 635c7fd. The original PR is #10120, but after many rebases it has been completely rewritten.