convert @babel/helper-function-name to TypeScript #12486
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/35399/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1e1868f:
|
nicolo-ribaudo
added
the
Flow -> TS
JLHwung
force-pushed
the
ts-migration/babel-helper-function-name
branch
from
7607e40
to
a64e701
Compare
| @@ -2,7 +2,7 @@ import getFunctionArity from "@babel/helper-get-function-arity"; | |||
| import template from "@babel/template"; | |||
| import * as t from "@babel/types"; | |||
|
|
|||
| const buildPropertyMethodAssignmentWrapper = template(` | |||
| const buildPropertyMethodAssignmentWrapper = template.statement(` | |||
There was a problem hiding this comment.
Q: Why do we need this change?
There was a problem hiding this comment.
this way it was more granular type (just t.Statement instead of union of all possible options - I remember in some place ts was complaining about possible array instead of ast node), however - later I anyway added more typecasts… so this is no longer needed - reverting it
| @@ -150,7 +153,10 @@ function visit(node, name, scope) { | |||
| * @param {NodePath} param0 | |||
| * @param {Boolean} localBinding whether a name could shadow a self-reference (e.g. converting arrow function) | |||
| */ | |||
| export default function ({ node, parent, scope, id }, localBinding = false) { | |||
| export default function ( | |||
| { node, parent, scope, id }: any, | |||
There was a problem hiding this comment.
| { node, parent, scope, id }: any, | |
| { node, parent, scope, id }: { node: any, parent: any, scope: any, id: any }, |
It's still full of anys, but at least it gives basic safety against typos and autocompletion.
There was a problem hiding this comment.
done,
Ideally it should use NodePath, but there is an issue about circular dependency to use it
zxbodya
force-pushed
the
ts-migration/babel-helper-function-name
branch
from
a64e701
to
1e1868f
Compare
github-actions
bot
added
the
outdated
@babel/helper-function-name part of #11578