Lazily inject imports to the JSX runtime #12493
Conversation
nicolo-ribaudo
added
PR: Bug Fix 🐛
| const foo = /*#__PURE__*/undefined.jsx("p", {}); | ||
| var _reactJsxRuntime = require("react/jsx-runtime"); | ||
|
|
||
| const foo = /*#__PURE__*/_reactJsxRuntime.jsx("p", {}); |
There was a problem hiding this comment.
This fixture shows that it's fixed.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/35275/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e9daba1:
|
nicolo-ribaudo
changed the title
| let reference = pass.get( | ||
| `@babel/plugin-react-jsx/imports/${importName}`, | ||
| ); |
There was a problem hiding this comment.
I'm just wondering - does keeping this in a state has any benefit here? i mean - wouldn't a closure state do the trick just fine? I don't expect any change here - just wondering if there is something I'm not thinking about
There was a problem hiding this comment.
The plugin might be cached, so multiple runs of the plugin over the same file could have the same closure. Thus, we would still need to have a programNode -> imports WeakMap to avoid using imports attatched in a separate Babel run.
nicolo-ribaudo
force-pushed
the
fix-react-automatic-undefined
branch
from
9ad420a
to
e9daba1
Compare
|
@nicolo-ribaudo Did this PR also fix #12468 (comment) ? |
|
I don't think, there isn't a call to |
github-actions
bot
added
the
outdated
Injecting automatic imports to react on
Program:enterhas a problem: if a plugin later injects some JSX, the automatic imports logic cannot inject the necessary import.This PR changes the injection to happen when transforming the JSX element, so that it works with injected JSX.