chore: always check yarn lock and dedupe during update #12508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Internal 🏠
nicolo-ribaudo
approved these changes
Dec 15, 2020
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/35340/ |
JLHwung
commented
Dec 15, 2020
| env: | ||
| YARN_ENABLE_SCRIPTS: false # disable post-install scripts | ||
| YARN_NODE_LINKER: pnp # use pnp linker for better performance: it's meant to update yarn cache only | ||
| run: | | ||
| yarn dedupe --check | ||
| yarn install --immutable | ||
| yarn install --immutable --skip-builds |
There was a problem hiding this comment.
Note that since we have run yarn install --immutable --skip-builds unconditionally, GitHub CI now update the cache even if the yarn.lock is not changed and cache was hit. It adds 5 extra seconds to current CI: https://github.com/babel/babel/pull/12508/checks?check_run_id=1557856427#step:13:1
actions/cache#489 will eventually solve this issue.
existentialism
approved these changes
Dec 15, 2020
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ef4e92b:
|
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn.lockneeds to be updatedContext: In #12433 we modified the package.json of
@babel/code-framebut forgot to commit Yarn lock changes. The CI does not bail because the install check is skipped when CI has yarn cache for theyarn.lock. This PR refines the CI step so that it always check whetheryarn.lockneed to be modified. I catch this issue when my fork fails: https://github.com/JLHwung/babel/runs/1557682750The CI now bails as expected: https://github.com/babel/babel/runs/1557842082
The following commit fixes this error.