Improve AST node definitions in @babel/types #12510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/35474/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 06cdbb7:
|
JLHwung
reviewed
Dec 15, 2020
| @@ -1542,6 +1544,7 @@ export interface ClassPrivateProperty extends BaseNode { | |||
| value: Expression | null; | |||
| decorators: Array<Decorator> | null; | |||
| static: any; | |||
| typeAnnotation: TypeAnnotation | TSTypeAnnotation | Noop | null; | |||
There was a problem hiding this comment.
typeAnnotation is an optional property: Babel does not assign it to AST unless flow or typescript plugin are enabled.
There was a problem hiding this comment.
added the same definition as in ClassProperty
|
Could you rebase and re-build the generated type definitions? |
nicolo-ribaudo
added
pkg: types
PR: Internal 🏠
yes, will do |
…tch parser results updated definitions for EnumBooleanBody EnumNumberBody EnumStringBody
zxbodya
force-pushed
the
ts-migration/babel-types
branch
from
a1a7848
to
06cdbb7
Compare
JLHwung
approved these changes
Dec 15, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After adding
nodeargument type annotations for @babel/generator (in #12487) found some incomplete or not correct AST node definitions - extracted it into separate PR