Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark optional AST fields in generated type definitions #12511

Merged
merged 1 commit into from Dec 15, 2020
Merged

Mark optional AST fields in generated type definitions #12511

merged 1 commit into from Dec 15, 2020

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Dec 15, 2020 •
edited

Q                       A
Fixed Issues? Fixes /#12510 (comment)
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

cc @zxbodya

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/35450/

zxbodya
zxbodya approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@zxbodya zxbodya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 53e492e:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@zxbodya
Copy link
Contributor

zxbodya commented Dec 15, 2020

btw comment probably needs to be updated, it looks it will close #12510 when merged…

JLHwung
JLHwung approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

@nicolo-ribaudo nicolo-ribaudo merged commit 0ea0650 into babel:main Dec 15, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the ts-optional-ast-fields branch December 15, 2020 22:19
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Mar 17, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zxbodya zxbodya zxbodya approved these changes

@JLHwung JLHwung JLHwung approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nicolo-ribaudo @babel-bot @zxbodya @JLHwung