Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release-tool and define implicit deps for @babel/runtime #12527

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Dec 18, 2020

Q                       A
Any Dependency Changes? Updated yarn release-tool
License MIT

This is another step towards automation.

When publishing, we have an "implicit" dependency between @babel/helpers and the @babel/runtime-* packages, but release-tool doesn't detect changes to @babel/runtime when @babel/helpers is changed because it only affects the lib folder (which is .gitignored).
For this reason, I almost never run make new-version, but I usually first run yarn release-tool version -f @babel/standalone, check if @babel/helpers will be published, and if it will be I abort and run yarn release-tool -f @babel/runtime -f @babel/runtime-corejs2 -f @babel/runtime-corejs3 -f @babel/standalone.

This PR includes nicolo-ribaudo/yarn-plugin-babel-release-tool@7985aaf: it now automatically publishes @babel/runtime-* when @babel/helpers changes.

@nicolo-ribaudo nicolo-ribaudo added PR: Internal 🏠 A type of pull request used for our changelog categories PR: Dependency ⬆️ area: publishing process labels Dec 18, 2020
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/35801/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d4afe8c:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guess there's no way to test the implicit part other than trying it somewhere?

@nicolo-ribaudo
Copy link
Member Author

I tested it locally: on main it doesn't publish @babel/helpers, but as soon as I commit a change to @babel/helpers it also bumps @babel/runtime&co

@nicolo-ribaudo nicolo-ribaudo merged commit 56c7024 into babel:main Dec 19, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the update-release-tool-implicitDependencies branch December 19, 2020 00:13
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Mar 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: publishing process outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Dependency ⬆️ PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants