Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip discriminant when renamer starts from SwitchStatement. fix #12148 #12530

Merged
merged 2 commits into from
Dec 22, 2020
Merged

skip discriminant when renamer starts from SwitchStatement. fix #12148 #12530

merged 2 commits into from
Dec 22, 2020

Conversation

Zzzen
Copy link
Contributor

@Zzzen Zzzen commented Dec 20, 2020 •
edited by gitpod-io bot

Q                       A
Fixed Issues? Fixes #12148
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@babel-bot
Copy link
Collaborator

babel-bot commented Dec 20, 2020 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/35960/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 20, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fcc542d:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo nicolo-ribaudo added pkg: traverse (scope) PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Dec 20, 2020
nicolo-ribaudo
nicolo-ribaudo approved these changes Dec 20, 2020
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a future major release, we should probably consider a SwitchBody node: it introduces a new scope, and having a dedicated node for it would make things clearer/easier.

@Zzzen
Copy link
Contributor Author

Zzzen commented Dec 21, 2020

Yes. It's called CaseBlock in typescript though.

@nicolo-ribaudo nicolo-ribaudo merged commit e08f68b into babel:main Dec 22, 2020
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Mar 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: traverse (scope) PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Same variables in switch/case is corrupts code
4 participants
@Zzzen @babel-bot @existentialism @nicolo-ribaudo