Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updater does not work on main branch #12537

Merged
merged 1 commit into from Dec 21, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Dec 21, 2020

Co-authored-by: Nicolò Ribaudo nicolo.ribaudo@gmail.com

Q                       A
Fixed Issues? The test262 updater does not work on main branch: https://github.com/babel/babel/actions/runs/436329172
License MIT

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/36095/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d197da8:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot be sure that this works until we merge it (the old PR was working, but it didn't after being merged into main 🤷).

This PR is based on this log: we have to assume that for main it's still refs/heads/main (I have that ref locally).

@JLHwung JLHwung merged commit bb2343a into babel:main Dec 21, 2020
@JLHwung JLHwung deleted the fix-test-update-test262 branch December 21, 2020 22:06
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Mar 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: test262 outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants