[babel 8] type checking preset-flow options #12751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c4e7b1e:
|
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44749/ |
JLHwung
force-pushed
the
type-checking-preset-flow-options
branch
from
4d55abd
to
ff5d3a6
Compare
| return { all }; | ||
| } | ||
|
|
||
| return { |
There was a problem hiding this comment.
Could you use if/else instead of the early return, so that it's easier to automate the removal of process.env.BABEL_8_BREAKING? 🙏
nicolo-ribaudo
approved these changes
Feb 4, 2021
JLHwung
force-pushed
the
type-checking-preset-flow-options
branch
from
39a4e4f
to
e188d7f
Compare
hzoo
reviewed
Mar 25, 2021
|
|
||
| export default function normalizeOptions(options = {}) { | ||
| let { all } = options; | ||
| const { allowDeclareFields } = options; |
There was a problem hiding this comment.
nbd, maybe just do one var declaration?
There was a problem hiding this comment.
ESLint will complain, because one has let and one has const.
hzoo
approved these changes
Mar 25, 2021
nicolo-ribaudo
changed the title
github-actions
bot
added
the
outdated
JLHwung
added
PR: Breaking Change 💥
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BABEL_8_BREAKINGflagpreset-flownow depends onhelper-validator-optionThis PR was derived from #10927. It focuses on checking
@babel/preset-flowoptions only.