New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix esmodules: true
without specified browsers
#12908
Conversation
nicolo-ribaudo
commented
Feb 25, 2021
Q | A |
---|---|
Fixed Issues? | Fixes #12903 |
Patch: Bug Fix? | Yes |
Major: Breaking Change? | |
Minor: New Feature? | |
Tests Added + Pass? | Yes |
Documentation PR Link | |
Any Dependency Changes? | |
License | MIT |
@@ -205,7 +205,7 @@ export default function getTargets( | |||
|
|||
// `esmodules` as a target indicates the specific set of browsers supporting ES Modules. | |||
// These values OVERRIDE the `browsers` field. | |||
if (esmodules && (esmodules !== "intersect" || !browsers)) { | |||
if (esmodules && (esmodules !== "intersect" || !shouldParseBrowsers)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
browsers
was always assigned at line 194
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/42798/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit dda6659:
|
be5576e
to
dda6659
Compare