Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install psmisc in Vue e2e tests on CircleCI #13162

Merged
merged 3 commits into from
Apr 15, 2021

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Apr 15, 2021

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This is unrelated to the e2e vue fix we just merged.

Vue e2e tests on CircleCI recently started failing because the fuser command is not installed:

I don't know why it stopped working, but maybe this PR fixes it 🤷

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 15, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 045ba38:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented Apr 15, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45280/

JLHwung
JLHwung previously approved these changes Apr 15, 2021
@nicolo-ribaudo nicolo-ribaudo dismissed JLHwung’s stale review April 15, 2021 23:03

It looks like psmisc is not the correct package

@nicolo-ribaudo
Copy link
Member Author

Ok now psmisc is correctly installed, but there is another error because the Babel 8 patch has some conflicts

Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want still want to pin the commit somehow since it's a dev branch?

@nicolo-ribaudo
Copy link
Member Author

nicolo-ribaudo commented Apr 15, 2021

Even if it's a dev branch it's always green, so it isn't a big problem. Specifically, this PR was caused by some change in CircleCI and not in vue-cli.

@nicolo-ribaudo nicolo-ribaudo merged commit eaea969 into babel:main Apr 15, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the vue-e2e-circleci-fuser branch April 15, 2021 23:50
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: tests outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Fixes failing main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants