Fixed the ParseResult type in @babel/core
#14333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andarist
commented
Mar 4, 2022
| type AstRoot = t.File | t.Program; | ||
|
|
||
| export type ParseResult = AstRoot; | ||
| export type ParseResult = ReturnType<typeof parse>; |
There was a problem hiding this comment.
this represents something like:
type ParseResult = File & {
errors: ParseError[];
}
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51409/ |
nicolo-ribaudo
approved these changes
Mar 5, 2022
There was a problem hiding this comment.
Note that @babel/core types are not published, so if you are using them they may come from DefinitelyTyped.
|
That might be right - should I also prepare a PR to the DefinitelyTyped then? |
|
Yes please! (even if we don't maintain those type definitions) |
JLHwung
approved these changes
Mar 5, 2022
|
I've created a corresponding PR to DefinitelyTyped: DefinitelyTyped/DefinitelyTyped#59153 |
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2Those types IMHO should be consistent since
@babel/corejust~ calls to@babel/parserhere.