Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary object accesses for legibility #14446

Merged
merged 1 commit into from
Apr 10, 2022

Conversation

conartist6
Copy link
Contributor

@conartist6 conartist6 commented Apr 10, 2022

Q                       A
Fixed Issues? No
Patch: Bug Fix? No
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? No
License MIT

Minor stylistic cleanup for readability.

@babel-bot
Copy link
Collaborator

babel-bot commented Apr 10, 2022

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51655/

@nicolo-ribaudo
Copy link
Member

It looks like your fork is very old, could you try rebasing?

@conartist6
Copy link
Contributor Author

conartist6 commented Apr 10, 2022

Rebased. I just used github's "edit this file" feature to make the PR, but it seems to have targeted master as the base to make the change against instead of main. I don't think that was something I chose, but I could be wrong.

@nicolo-ribaudo nicolo-ribaudo changed the base branch from master to main April 10, 2022 13:40
@nicolo-ribaudo
Copy link
Member

Changed it 👍 (it can be done by clicking on "Edit" near the PR title)

@conartist6
Copy link
Contributor Author

conartist6 commented Apr 10, 2022

I made a second PR as a test -- it seems the problem was caused by my fork being old and having the wrong default branch (master).

@nicolo-ribaudo nicolo-ribaudo merged commit b35ff0f into babel:main Apr 10, 2022
@conartist6 conartist6 deleted the patch-1 branch April 10, 2022 13:59
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 11, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants