[babel 8] Recover from error when parsing <T>() => {}</T>
#14616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
commented
May 29, 2022
| // If the state was cloned in the JSX parsing branch above but there | ||
| // have been any error in the tryParse call, this.state is set to state | ||
| // so we still need to clone it. | ||
| if (!state || state === this.state) state = this.state.clone(); |
There was a problem hiding this comment.
This change is because the below tryParse call should always receive a clone of this.state, and not this.state itself.
nicolo-ribaudo
commented
May 29, 2022
| if (!parameter.constraint) { | ||
| // A single type parameter must either have constraints | ||
| // or a trailing comma, otherwise it's ambiguous with JSX. | ||
| this.raise(TSErrors.SingleTypeParameterWithoutTrailingComma, { |
There was a problem hiding this comment.
I moved this error within the this.tryParse call, so that it know that there is a problem with the function. Otherwise, when parsing <T>() => {}</T> it would give the precedence to the arrow function because it thought that <T>() => {} could be pared without errors.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52071/ |
|
It looks like the prettier test is not failing anymore on |
JLHwung
approved these changes
May 31, 2022
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @liuxingbaoyu