New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable test variance-annotations-with-jsx
with babel8
#14626
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52099/ |
I'm having a weird problem here. |
The generator test ignores all the recoverable errors when |
Strangely, when I debug, only the first error is included in the parsing result. |
Let me try cloning this PR locally 🤔 |
Is it in the Babel 7 or Babel 8 test? |
Thanks! These bugs such as redefinition errors should exist in both babel 7 and 8. |
Uh well, you see different errors because the generator test and the parser tests have different inputs! The parser tests is londer and contain many invalid statements, so we test that we can still parse them. For the generator we only care about printing them, and we only test valid inputs because invalid inputs are not 100% represented in the AST. For example, |
Oh, thanks! I see, sorry for not noticing. |
Fixes #1, Fixes #2