Enforce _foo.default || _foo to import lib files in tests
#14673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52268/ |
This comment was marked as resolved.
This comment was marked as resolved.
liuxingbaoyu
approved these changes
Jun 19, 2022
nicolo-ribaudo
force-pushed
the
import-default-test-fallback
branch
from
5721604
to
819ae34
Compare
nicolo-ribaudo
force-pushed
the
import-default-test-fallback
branch
from
16d80cb
to
83c8a1c
Compare
nicolo-ribaudo
changed the title
_foo.default || _foo fallback to import lib files in tests_foo.default || _foo fallback to import lib files in tests
|
I'm merging this with a single approval, since:
|
nicolo-ribaudo
changed the title
_foo.default || _foo fallback to import lib files in tests_foo.default || _foo to import lib files in tests
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another step towards #13414. Unfortunately importing a default import from ESM has different behavior depending on if the imported file is compiled to CJS or not: in one case you need to use
import _x; const x = x.default, in the other case onlyimport x;.This PR updates our tests (which are currently our only ESM files) to use
_foo.default || _foo, so that they work both with ESM sources and with compiled sources.Since we still only runs our tests by compiling our sources to CommonJS, I added a custom (temporary) lint rule to enforce it.