Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to TS 4.7 #14686

Merged
merged 3 commits into from Jun 23, 2022
Merged

Update to TS 4.7 #14686

merged 3 commits into from Jun 23, 2022

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jun 22, 2022 •
edited

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This currently fails because of microsoft/TypeScript#49643, it's just to show the error.

@babel-bot
Copy link
Collaborator

babel-bot commented Jun 22, 2022 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52335/

JLHwung
JLHwung approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use @ts-expect-error to suppress new errors so we can move on. After this issue get fixed, TS will remind us with the "unused expect-error directive" message.

@nicolo-ribaudo nicolo-ribaudo marked this pull request as ready for review June 23, 2022 21:59
@nicolo-ribaudo nicolo-ribaudo merged commit 399a1b4 into babel:main Jun 23, 2022
@nicolo-ribaudo nicolo-ribaudo deleted the up-ts-2 branch June 23, 2022 22:25
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Sep 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Dependency ⬆️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nicolo-ribaudo @babel-bot @JLHwung @liuxingbaoyu