Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update to unicode15 #14931

Merged
merged 2 commits into from Sep 14, 2022
Merged

chore: Update to unicode15 #14931

merged 2 commits into from Sep 14, 2022

Conversation

liuxingbaoyu
Copy link
Member

@liuxingbaoyu liuxingbaoyu commented Sep 14, 2022 •
edited by gitpod-io bot

Q                       A
License MIT

@babel-bot
Copy link
Collaborator

babel-bot commented Sep 14, 2022 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52938/

JLHwung
JLHwung reviewed Sep 14, 2022
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a new test in packages/babel-helper-validator-identifier/test/identifier.spec.js? For example, U+31350 is a newly added character in Unicode 15.

@nicolo-ribaudo nicolo-ribaudo merged commit c9d0c40 into babel:main Sep 14, 2022
@liuxingbaoyu liuxingbaoyu deleted the unicode-15 branch September 14, 2022 14:22
@nicolo-ribaudo nicolo-ribaudo changed the title chore: Update unicode15 and fix ci chore: Update to unicode15 Sep 14, 2022
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 15, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Dependency ⬆️ PR: Fixes failing main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liuxingbaoyu @babel-bot @JLHwung @nicolo-ribaudo