Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: TypeScript plugin drops class export #14945

Closed
1 task
marvinhagemeister opened this issue Sep 17, 2022 · 1 comment 路 Fixed by #14946
Closed
1 task

[Bug]: TypeScript plugin drops class export #14945

marvinhagemeister opened this issue Sep 17, 2022 · 1 comment 路 Fixed by #14946
Assignees
Labels
area: typescript i: bug outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: traverse (scope)

Comments

@marvinhagemeister
Copy link
Contributor

馃捇

  • Would you like to work on a fix?

How are you using Babel?

Programmatic API (babel.transform, babel.parse)

Input code

declare class Signal<T = any> {
	value: T
}

function Signal(this: Signal, value?: unknown) {
	this.value = value
}

export { Signal };

Configuration file name

No response

Configuration

{
  "presets": ["@babel/preset-typescript"]
}

Current and expected behavior

Actual output:

function Signal(value) {
  this.value = value;
}

export {};

Expected output, see this TypeScript playground:

function Signal(value) {
    this.value = value;
}
export { Signal };

Basically there is a compilation difference between babel's TypeScript preset and TypeScript itself.

Environment

OS: macOS 12.5.1
Node: 18.8.0
Yarn: 1.22.17
@babel/core: 7.19.1
@babel/preset-typescript: 7.18.6
Monorepo: no

Possible solution

No response

Additional context

My assumption is that babel sees the declare class Signal {} line and tags it as a type-only thing or something like that.

@babel-bot
Copy link
Collaborator

Hey @marvinhagemeister! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite.

@liuxingbaoyu liuxingbaoyu self-assigned this Sep 17, 2022
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: typescript i: bug outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: traverse (scope)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants